fix(common): harden the vikunja client and sync against malformed responses #14

Merged

gravityfargo merged 3 commits from harden-vikunja-client into main 2026-08-19 04:21:13 +00:00

Conversation 0 Commits 3 Files changed 4 +46 -12

gravityfargo commented 2026-08-19 04:06:42 +00:00

Owner

Copy link

Closes #12 — all four deferred review findings:

• projects() now raises RestAdapterError on a 2xx body that is not a list instead of silently corrupting the accumulated result.
• The pagination walk is capped at MAX_PAGES (100); a server that always fills the page becomes a clear error instead of an infinite loop.
• _ensure_parent uses the same explicit is not None adopt check as _resolve_child, so a falsy-but-present dict can never trigger a spurious create.
• RestAdapter.put gains an error-path test matching get/post.

Closes #12 — all four deferred review findings: - `projects()` now raises `RestAdapterError` on a 2xx body that is not a list instead of silently corrupting the accumulated result. - The pagination walk is capped at `MAX_PAGES` (100); a server that always fills the page becomes a clear error instead of an infinite loop. - `_ensure_parent` uses the same explicit `is not None` adopt check as `_resolve_child`, so a falsy-but-present dict can never trigger a spurious create. - `RestAdapter.put` gains an error-path test matching `get`/`post`.

gravityfargo added 3 commits 2026-08-19 04:06:42 +00:00

fix(common): reject non-list pages and cap the vikunja pagination walk ffd8c30718

refactor(project): align _ensure_parent's adopt check with _resolve_child 2d07c8e462

test(common): cover the rest adapter's put error path 0e20a9b58f

gravityfargo merged commit 0e20a9b58f into main 2026-08-19 04:21:13 +00:00

gravityfargo deleted branch harden-vikunja-client 2026-08-19 04:21:14 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gravityfargo/local-tools!14

No description provided.