Harden the vikunja client and sync against malformed responses #12

New issue

Closed

opened 2026-08-14 22:56:23 +00:00 by gravityfargo · 0 comments

gravityfargo commented

2026-08-14 22:56:23 +00:00

Owner

Deferred review findings from the vikunja-project-sync implementation (all approved-with-notes, none blocking):

common/vikunja.py projects() trusts the parsed body to be a list; a malformed 2xx (proxy quirk, API drift) silently corrupts the accumulated result instead of raising RestAdapterError.
The pagination walk has no upper bound: a server always answering exactly per_page items loops forever. A generous page cap turning the hang into a clear error is enough.
project/sync.py _ensure_parent resolves via by_parent_title.get(...) or client.create_project(...) while _resolve_child uses an explicit is not None check; align on the latter so a falsy-but-present dict can never trigger a spurious create.
RestAdapter.put has no error-path test, unlike get/post (coverage holds via the shared _request, symmetry only).

Deferred review findings from the vikunja-project-sync implementation (all approved-with-notes, none blocking): - `common/vikunja.py` `projects()` trusts the parsed body to be a list; a malformed 2xx (proxy quirk, API drift) silently corrupts the accumulated result instead of raising `RestAdapterError`. - The pagination walk has no upper bound: a server always answering exactly `per_page` items loops forever. A generous page cap turning the hang into a clear error is enough. - `project/sync.py` `_ensure_parent` resolves via `by_parent_title.get(...) or client.create_project(...)` while `_resolve_child` uses an explicit `is not None` check; align on the latter so a falsy-but-present dict can never trigger a spurious create. - `RestAdapter.put` has no error-path test, unlike `get`/`post` (coverage holds via the shared `_request`, symmetry only).

gravityfargo referenced this issue from a pull request that will close it,

2026-08-19 04:06:42 +00:00

fix(common): harden the vikunja client and sync against malformed responses #14

gravityfargo closed this issue

2026-08-19 04:21:14 +00:00