feat(thumbnails): log ffmpeg output on failure #22

Merged

gravityfargo merged 1 commit from feat/1-ffmpeg-logging-v2 into main

2026-05-03 17:34:09 +00:00

gravityfargo commented

2026-05-03 17:33:21 +00:00

Owner

Summary

Replaces #16 — that PR's branch ran the old (broken) workflow; this one is fresh off the new main with the fixed CI pipeline (#21).

Closes #1. ffmpeg's stderr was previously discarded silently — when video thumbnail generation failed, the resulting `ValueError` carried no diagnostic info.

Module-level logger (`athena_file.media.thumbnails`)
Non-zero return code raises `ValueError` with rc + stderr in the message AND emits an ERROR-level log line
DEBUG-level: stderr is also logged on success (gated by `logger.isEnabledFor` to avoid the decode cost when debug is off)
Inner `except ValueError: raise` lets our explicit failure pass through cleanly

Verification

`make test` → 247 passed

## Summary Replaces #16 — that PR's branch ran the old (broken) workflow; this one is fresh off the new main with the fixed CI pipeline (#21). Closes #1. ffmpeg's stderr was previously discarded silently — when video thumbnail generation failed, the resulting \`ValueError\` carried no diagnostic info. - Module-level logger (\`athena_file.media.thumbnails\`) - Non-zero return code raises \`ValueError\` with rc + stderr in the message AND emits an ERROR-level log line - DEBUG-level: stderr is also logged on success (gated by \`logger.isEnabledFor\` to avoid the decode cost when debug is off) - Inner \`except ValueError: raise\` lets our explicit failure pass through cleanly ## Verification - \`make test\` → 247 passed

gravityfargo added 1 commit

2026-05-03 17:33:21 +00:00

feat(thumbnails): log ffmpeg output on failure (#1 )

Run pytest tests / test (pull_request) Successful in 19s

Details

da349cd15c

Closes #1. ffmpeg's stderr was discarded silently. Now:

- module-level logger (athena_file.media.thumbnails)
- non-zero rc raises ValueError with rc + stderr in the message AND
  emits an ERROR-level log line so callers configured with logging
  see the cause
- DEBUG-level: stderr always logged on success too (gated by
  logger.isEnabledFor to avoid the decode cost when debug is off)

gravityfargo merged commit 5a32d88110 into main

2026-05-03 17:34:09 +00:00

gravityfargo deleted branch feat/1-ffmpeg-logging-v2

2026-05-03 17:34:09 +00:00

gravityfargo referenced this pull request from a commit

2026-05-03 17:34:09 +00:00

feat(thumbnails): log ffmpeg output on failure (#22)